Template talk:Crafting

From Lotro-Wiki.com
Jump to navigation Jump to search

Universal Optional Crafting Ingredient

I would like to get Universal_Optional_Crafting_Ingredient added to this template for the 100% crit chance it provides. Also, we would no longer need to add notes about using this item instead of the default "Critical-Trophy". Three ways this could be done:

  1. If "Critical-Trophy" has a value, automatically add the UOCI item below this one
  2. Add a new parameter called "Critical-Trophy-UOCI" which when set to true or yes would display a UOCI line
  3. Add "Critical-Trophy2", "Critical-Trophy-use2" parameters and set these to display the UOCI and 100%

Method 1 is the simplest and would not require us having to modify all the recipe pages to manually add the item. However, if there is an exception case where a Critical-Trophy can be used but UOCI is not permitted, this would not work. However, at present I don't know of any exception cases. Method 2 requires us to manually modify all the recipe pages that can use UOCI but it would be able to handle exception cases where UOCI is not supported Method 3 is the same as 2 except we are not implicitly supporting UOCI. However, this requires slightly more editing time per page.

Also, a bot could be considered for helping with methods 2 and 3. However, I think method 1 is the way to go unless there are exceptions.
Comments? Other suggestions? Sagarmatha (talk) 23:19, 21 August 2022 (UTC)

We could go with Method 1 even if there were exceptions and then use a modified Method2 where we set "Critical-Trophy-UOCI" to false or no to not display the UOCI line on exception pages. Sagarmatha (talk) 01:36, 22 August 2022 (UTC)
To my knowledge, there are actually lots of exceptions; pretty much every 'Single Use' recipe, where the optional component for increased crit chance output is a journal (and not some sort of 'shard')! These would include for instance all the recipes usually available at the levels that are evenly divisible by 10 (so lvl 20, 30, and so on), for each profession. As well as some notable rare drops (from instances and the like); such as the ones from Draigoch, and the armour, bracelets and pocket items that can be gotten in Rohan. In none of these can a Universal Optional Crafting Ingredient be used.
As such, I don't think option #1 would be a good solution here. As I see it, #3 would probably be the ideal one to go for; both in terms of general versatility/usefulness (in case they could be utilised in another situation as well), but also because of ease of understanding and use from a usability perspective (as seen from the viewpoint of an average user). So, option #3 would get my vote in this case. :)
--Stargazer (talk) 22:28, 23 August 2022 (UTC)
When I checked some single use recipes that use a journal for crit chance, they supported the UOCI. For example, the Metalsmith recipes for crafting tools or Battle Armour of the Mark Recipe. I'm not saying there aren't exceptions, but need a specific confirmed example. I can't recall if I have ever gotten any of the Rohan scroll cases as drops. Sagarmatha (talk) 20:36, 5 October 2022 (UTC)
I just checked Lotro Companion and it is showing the UOCI for Pauldrons of the Horse-lords Recipe found in Ancient Riddermark Scroll Case I. Sagarmatha (talk) 20:43, 5 October 2022 (UTC)

Modifications now in the sandbox

Modifications to support this change using method1 are in the sandbox. See the test cases for example output. Sagarmatha (talk) 21:26, 23 August 2022 (UTC)