Template talk:Fall Festival Trader

From Lotro-Wiki.com
Revision as of 00:46, 25 October 2014 by Snarpel (talk | contribs) (→‎Page is now a template: new section)
Jump to navigation Jump to search

Wrong Quantities?

While trying to implement Festival Skill: Potent Bird Seed I cut and pasted a portion of this table. In the process I think I've noticed two fundamental errors with how data is being displayed in this table. However, this might be a wiki-wide issue.

Reward Quantities: Rewards accepts a quantity as a variable in the item's entry within the table. So, for instance, Specimen Jars: Gross Bugs' image shows the icon with a quantity of 5. However, the 'Item to Receive' column specifically states '5 Specimen Jars: Gross Bugs'. To me this means we get 25 (5 stacks containing 5 each) - which is wrong! Keeping the stack quantity on the icon seems to be the most consistent usage. However to implement this would require altering the pop-up info for the items (the item page name is correct but not the Boilerplate:Item's name variable) and might have implications elsewhere in the wiki. (Please note that I previously altered the entry for Potent Bird Seed to remove the quantity since consumables and cosmetics are drops from the Poorly Hidden Chest and are not given in stacks of 5. So this one entry no longer implies 25 items total.)

Trade Quantities: The problem here is one of inconsistent usage. If we're going to place a quantity on the item's icon, then this column's data template needs to corrected. Currently it is the text and not the icon that receives the quantity. Placing the quantity on the icon would be more consistent with the game. I do not know the wiki commands necessary to implement this. -- DoIHaveTo (talk) 04:37, 21 October 2011 (EDT)

Keeping it short and sweet: Item information on the item's page itself should deal with only a single item, even if they're received/dropped/bartered in a stack. In this sense, you were correct to zap the "5" from Item:Potent Bird Seed. Item:Specimen Jars: Gross Bugs (et al.) should similarly be updated (and probably moved) to be just a single jar of gross bugs and so on. Sethladan 11:55, 21 October 2011 (EDT)

Page is now a template

Since this page is being transcluded into every festival page (after 2010) it clearly doesn't make sense to have it as a static page. I have converted it into a template which takes an optional "year" parameter which is used in conditional logic to shows the availability of items on different years. If the parameter is missing, which will happen for non-festival pages, the current year is used. The logic will need to be readjusted for each new festival.